feat(vote): add vote component #INF-169 #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
why520crazy
requested changes
Dec 17, 2019
src/vote/vote.component.ts
Outdated
Comment on lines
77
to
84
| (this._classNames || []).forEach((value: string) => { | ||
| this.renderer.removeClass(this._nativeElement, value); | ||
| }); | ||
|
|
||
| this._classNames = className; | ||
| this._classNames.forEach((value: string) => { | ||
| this.renderer.addClass(this._nativeElement, value); | ||
| }); |
There was a problem hiding this comment.
这个地方使用 UpdateHostClassService 他会自动做移除样式和追加样式的逻辑
| } | ||
|
|
||
| _setClassesByType() { | ||
| const className = []; |
There was a problem hiding this comment.
最好设置一个变量 initialized，否则会在加载组件的时候调用这个逻辑很多次
src/vote/vote.component.ts
Outdated
| templateUrl: './vote.component.html' | ||
| }) | ||
| export class ThyVoteComponent implements OnInit { | ||
| private _nativeElement: any; |
src/vote/vote.component.ts
Outdated
| } | ||
|
|
||
| @Input() | ||
| set thyVoteType(value: ThyVoteType) { |
There was a problem hiding this comment.
这个改成 thyLayout 最好, 去掉 Vote
why520crazy
approved these changes
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.